[python-server] Support python 3.5+ for all server-generators #2884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guillaume Smaha <[email protected]>
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
wing328
reviewed
May 20, 2019
| @@ -201,6 +201,7 @@ public void processOpts() { | |||
| } | |||
| supportingFiles.add(new SupportingFile("__main__.mustache", packagePath(), "__main__.py")); | |||
| supportingFiles.add(new SupportingFile("util.mustache", packagePath(), "util.py")); | |||
| supportingFiles.add(new SupportingFile("typing_patch.mustache", packagePath(), "typing_patch.py")); | |||
There was a problem hiding this comment.
Suggestion: what about naming it as typing_utils.py instead?
Patch sounds like the code is more like a workaround and not production ready
There was a problem hiding this comment.
Yes, it's is better with typing_utils.py
|
@GuillaumeSmaha when you've time, can we have a quick chat via https://gitter.im (ID: wing328) as I've a question about this PR? |
wing328
changed the title
This was referenced May 30, 2019
|
@GuillaumeSmaha thanks again for your contribution, which has been included in the v4.0.1 release (https://twitter.com/oas_generator/status/1135534738658062336) |
jimschubert
added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Jun 5, 2019
* 4.1.x: (56 commits) sync master Update compatibility table Ruby client: escape path parameters (OpenAPITools#3039) [gradle plugin] Release 4.0.1 fixes (OpenAPITools#3051) Update version to 4.0.2-SNAPSHOT (OpenAPITools#3047) Map number to double time since float is also parsed as double in Qt5 C++ (OpenAPITools#3046) Prepare 4.0.1 release (OpenAPITools#3041) [gradle] Reworking publishing pipeline (OpenAPITools#2886) [typescript-fetch] Fix uploading files (OpenAPITools#2900) Resolves OpenAPITools#2962 - Add properties config to Maven parameters (OpenAPITools#2963) fix(golang): Check error of xml Encode (OpenAPITools#3027) [C++][Restbed] Add handler callback methods (OpenAPITools#2911) Remove null checks for C# value types (OpenAPITools#2933) [python-server] Support python 3.7 for all server-generators (OpenAPITools#2884) Use golang's provided method names (gin) (OpenAPITools#2983) [python] Adding constructor parameters to Configuration and improving documentation (OpenAPITools#3002) Add new option to maven plugin's readme (OpenAPITools#3025) Engine param in maven plugin. (OpenAPITools#2881) Added support for patterns on model properties (OpenAPITools#2948) [csharp] Make API response headers dictionary case insensitive (OpenAPITools#2998) ...
pierre-quelin
added a commit
to pierre-quelin/swagger-codegen
that referenced
this pull request
Nov 18, 2021
Need to be more python version compatible OpenAPITools/openapi-generator#2884
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,. Default:3.4.x,4.0.xmaster.Description of the PR
This change allows support for python 3.5+ on all python-server-generators.
There are 2 issues requiring this fix:
PS: After running ./run/{LANG}-petstore.sh, I got change on the version and unrelated stuff like
- - write:pets. Should I revert this change ?